From: "HŒaavard Skinnemoen" <haavard.skinnemoen@atmel.com>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Cc: linux <linux-kernel@vger.kernel.org>,
Kristoffer Nyborg Gregertsen <gregerts@stud.ntnu.no>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 1/1] avr32/pata: avoid unnecessary memset
Date: Tue, 13 May 2008 00:45:00 +0200 [thread overview]
Message-ID: <4828C86C.7010007@atmel.com> (raw)
In-Reply-To: <20080512211529.1B7D97000089@mwinf2801.orange.fr>
Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/dma/iop-adma.c which :
Hmm...no, it's for drivers/ata/pata_at32.c.
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'info').
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Other than that, it looks good to me. Could you please fix the patch
description, add
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
and send it to Jeff?
Thanks a lot!
Haavard
> ---
>
> --- linux/drivers/ata/pata_at32.c 2008-04-17 04:49:44.000000000 +0200
> +++ linux/drivers/ata/pata_at32.c.cj 2008-05-12 23:07:10.000000000 +0200
> @@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
> if (!info)
> return -ENOMEM;
>
> - memset(info, 0, sizeof(struct at32_ide_info));
> -
> info->irq = irq;
> info->cs = board->cs;
>
>
>
prev parent reply other threads:[~2008-05-12 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 21:15 [PATCH 1/1] avr32/pata: avoid unnecessary memset Christophe Jaillet
2008-05-12 22:45 ` HŒaavard Skinnemoen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4828C86C.7010007@atmel.com \
--to=haavard.skinnemoen@atmel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregerts@stud.ntnu.no \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.