From: Ulrich Drepper <drepper@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davidel@xmailserver.org, mtk.manpages@gmail.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH 18/18] flag parameters: check magic constants
Date: Mon, 12 May 2008 20:54:34 -0700 [thread overview]
Message-ID: <482910FA.1080703@redhat.com> (raw)
In-Reply-To: <20080512201341.9ead6a9a.akpm@linux-foundation.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Morton wrote:
>> + BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
>
> The fifth assertion triggers with alpha allmodconfig.
This means the simple approach won't work for alpha.
The question is how to solve it? I suggest the following:
- - define SOCK_NONBLOCK to some value > 16 in include/asm-alpha/socket.h
- - add #ifndef SOCK_NONBLOCK around the definition in include/linux/net.h
- - in sys_socket, sys_socketpair, sys_paccept
int fflags = flags;
if (SOCK_NONBLOCK != O_NONBLOCK && (flags & SOCK_NONBLOCK)) {
fflags &= ~SOCK_NONBLOCK;
fflags |= O_NONBLOCK;
}
and use fflags instead of flags in the places where we pass it on.
This has no costs on platforms other than alpha.
Shall I sent a patch?
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkgpEPoACgkQ2ijCOnn/RHQ38gCgyVOI/urGeoIr7CFIfs8C7OyR
I80AniPGGWyxZYUQg0pQlySQHqX/UYlx
=5fA2
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2008-05-13 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 21:18 [PATCH 18/18] flag parameters: check magic constants Ulrich Drepper
2008-05-13 3:13 ` Andrew Morton
2008-05-13 3:45 ` David Miller
2008-05-13 3:54 ` Ulrich Drepper [this message]
2008-05-13 4:01 ` Andrew Morton
2008-05-13 4:02 ` David Miller
2008-05-13 4:21 ` Ulrich Drepper
2008-05-13 4:39 ` David Miller
2008-05-13 5:04 ` Andrew Morton
2008-05-13 5:10 ` Ulrich Drepper
2008-05-13 5:19 ` Andrew Morton
2008-05-13 5:42 ` Ulrich Drepper
2008-05-14 4:43 ` Andrew Morton
2008-05-23 5:22 ` Andrew Morton
2008-05-23 14:31 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482910FA.1080703@redhat.com \
--to=drepper@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.