From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, LKML <linux-kernel@vger.kernel.org>,
Eric Paris <eparis@redhat.com>
Subject: Re: race in audit_log_untrusted_string for task_struct::comm
Date: Mon, 17 Mar 2014 09:01:45 -0400 [thread overview]
Message-ID: <4829575.y6dA3xFjkS@x2> (raw)
In-Reply-To: <20140315232846.GE27244@madcap2.tricolour.ca>
On Saturday, March 15, 2014 07:28:46 PM Richard Guy Briggs wrote:
> I'm inclined to go get_task_comm() in all 5 locations, but if we care
> more about locking overhead, I'll switch to memcpy().
>
> Steve, do we care about the integrity of the comm field?
In the case of interpreters, its about the only thing we know about the
application being executed. For example, a shell script will have exe=/bin/sh,
so comm= is our only clue.
-Steve
prev parent reply other threads:[~2014-03-17 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 23:28 race in audit_log_untrusted_string for task_struct::comm Richard Guy Briggs
2014-03-15 23:29 ` [PATCH] audit: get comm using lock to avoid race in string printing Richard Guy Briggs
2014-03-18 17:37 ` Stephen Smalley
2014-03-18 17:54 ` Richard Guy Briggs
2014-03-15 23:29 ` [PATCH] audit: copy comm " Richard Guy Briggs
2014-03-15 23:29 ` Richard Guy Briggs
2014-03-17 13:01 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4829575.y6dA3xFjkS@x2 \
--to=sgrubb@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.