All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Turton <nturton@solarflare.com>
To: "Shan, Haitao" <haitao.shan@intel.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	"Jiang, Yunhong" <yunhong.jiang@intel.com>
Subject: Re: [PATCH 6/6] Add MSI support to XEN
Date: Tue, 13 May 2008 10:57:29 +0100	[thread overview]
Message-ID: <48296609.8060603@solarflare.com> (raw)
In-Reply-To: <823A93EED437D048963A3697DB0E35DE014F156F@pdsmsx414.ccr.corp.intel.com>

I tried the latest unstable tree on a NIC which supports both MSI and
MSI-X.  When the driver was configured to use MSI mode, everything
worked fine but when it was configured to use MSI-X, the call to
pci_enable_msix succeeded but the interrupt didn't work.  Have these
patches been seen to work on an MSI-X device?

In msix_capability_init (drivers/pci/msi-xen.c), there's a loop which
unmaps the old pirqs.  Shouldn't there be some similar code in
msi_capability_init?  I can't see any reason for the inconsistency
between the two functions.

Would it be possible to extend this code so that a PV backend driver
could map different MSI-X entries on a PCI device into different guests?
We already have frontend/backend drivers which allow multiple guests to
securely access the PCI memory of a single NIC and would like to extend
those drivers to map MSI-X interrupts directly to guests.  I
still don't understand enough about the new hypercalls to see how that
would work.

Cheers, Neil.

  parent reply	other threads:[~2008-05-13  9:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30  7:25 [PATCH 6/6] Add MSI support to XEN Shan, Haitao
2008-04-30  7:48 ` Jan Beulich
2008-04-30  8:15   ` Shan, Haitao
2008-04-30  8:49     ` Jan Beulich
2008-05-13  9:57 ` Neil Turton [this message]
2008-05-13 13:52   ` Haitao Shan
2008-05-14 13:36     ` Neil Turton
2008-05-14 15:49       ` Haitao Shan
2008-05-15  9:08         ` Neil Turton
2008-05-15  8:50       ` [PATCH] Not unmap all MSI-X pirqs when enabling MSI-X Shan, Haitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48296609.8060603@solarflare.com \
    --to=nturton@solarflare.com \
    --cc=haitao.shan@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.