From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
Subject: Re: [PATCH] Add syntax check for block devices
Date: Tue, 13 May 2008 19:33:08 +0900
Message-ID: <48296E64.8060504@ab.jp.nec.com>
References: <42C8B419161D9Fkanno.masaki@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------070801040806090205090508"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <42C8B419161D9Fkanno.masaki@jp.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------070801040806090205090508
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit

Hi,

I cannnot boot a guest with disks of 'tap' type specified
in the config file since cs 17617, unfortunately :-(
Attached patch would fix the issue.

Thanks,
    -- Yosuke

Masaki Kanno wrote:
> Hi,
> 
> If we define wrong values to a disk parameter in domain configuration 
> files, we get an error message or a guest OS panic.
> 
>  1. If we define a wrong disk type, xm create command error occurs 
>     about 100 seconds later.
>       e.g.  disk=['xyz:/xen/root-vm1.img,hda1,w']
> 
>  2. If we forget a disk type, a guest OS panic occurs.
>       e.g.  disk=['/xen/root-vm1.img,hda1,w']
> 
> This patch adds syntax checks of disk types. 
> 
> 
> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
> 
> Best regards,
>  Kan
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


--------------070801040806090205090508
Content-Type: all/allfiles;
 name="blk_syntax_check_tap.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="blk_syntax_check_tap.patch"

Xend: Fix blkif type check for tap devices.

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>

diff -r 0a8fc1a62796 tools/python/xen/xend/server/blkif.py
--- a/tools/python/xen/xend/server/blkif.py	Mon May 12 11:19:09 2008 +0100
+++ b/tools/python/xen/xend/server/blkif.py	Tue May 13 10:59:07 2008 +0900
@@ -56,9 +56,10 @@ class BlkifController(DevController):
         else:
             try:
                 (typ, params) = string.split(uname, ':', 1)
-                if typ not in ('phy', 'file'):
+                if typ not in ('phy', 'file', 'tap'):
                     raise VmError(
-                        'Block device must have "phy" or "file" specified to type')
+                        'Block device must have "phy", "file" or "tap" '
+                        'specified to type')
             except ValueError:
                 raise VmError(
                     'Block device must have physical details specified')

--------------070801040806090205090508
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------070801040806090205090508--