From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] bugs in flush_cache
Date: Wed, 14 May 2008 01:18:01 +0900 [thread overview]
Message-ID: <4829BF39.50503@ruby.dti.ne.jp> (raw)
In-Reply-To: <44f4144c0805130858x4bc68ae8s77d223216fc7b08a@mail.gmail.com>
Eyal Bari wrote:
> in your version of the function the iterated cache ops second argument
> was start_addr which stay constant.
Probably already fixed in the latest git. See below commit:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=188e94c370621708d13547d58dbc6ed3c5602aa8
> the second bug is that it doesn't iterate over the entire range:
> for example:
> if size is 42 and the cache line size is 32 - it takes two cache lines
> to cache this buffer
> your version will iterate only over one cache line
> my version will iterate over two cache line covering the entire range
Note that (addr == aend) is evaluated *after* cache_op()s.
If start_addr = 0x80000000, size = 42, CFG_CACHE_LINE_SIZE = 32,
cache_op( , 0x80000000) and cache_op( , 0x80000020) will be done.
I hope I don't miss anything.
next prev parent reply other threads:[~2008-05-13 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <44f4144c0805130526i18255f76l38633a38230816c4@mail.gmail.com>
[not found] ` <48299557.4020706@ruby.dti.ne.jp>
2008-05-13 15:58 ` [U-Boot-Users] bugs in flush_cache Eyal Bari
2008-05-13 16:18 ` Shinya Kuribayashi [this message]
2008-05-13 18:16 ` Eyal Bari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4829BF39.50503@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.