From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>
Cc: Martin Michlmayr <tbm@cyrius.com>,
linux-ide@vger.kernel.org, nico@cam.org, buytenh@wantstofly.org
Subject: Re: sata_mv on Orion: CONFIG_SATA_PMP=y needed even when no multiplier
Date: Tue, 13 May 2008 17:09:18 -0400 [thread overview]
Message-ID: <482A037E.4070504@rtr.ca> (raw)
In-Reply-To: <48295533.4080800@gmail.com>
Tejun Heo wrote:
> Mark Lord wrote:
..
>> I suppose we could just always ask for the extra soft-reset here (?)
>
> Hmm... sata_mv doesn't do device classification, right? If so, it
> should return -EAGAIN on success to tell EH to perform follow-up SRST.
..
Right now, mv_hardreset() is just a wrapper around sata_link_hardreset(),
and it just returns whatever it gets back from sata_link_hardreset().
And sata_link_hardreset() only returns -EAGAIN for hosts that support PMP.
Should sata_link_hardreset() instead always return -EAGAIN instead of 0 ?
Because that's essentially what we'd be doing by changing mv_hardreset()
to do that.
???
next prev parent reply other threads:[~2008-05-13 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:28 sata_mv on Orion: CONFIG_SATA_PMP=y needed even when no multiplier Martin Michlmayr
2008-05-12 15:49 ` Mark Lord
2008-05-13 8:45 ` Tejun Heo
2008-05-13 21:09 ` Mark Lord [this message]
2008-05-13 21:12 ` Mark Lord
2008-05-13 21:18 ` Mark Lord
2008-05-13 22:55 ` Mark Lord
2008-05-14 7:05 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482A037E.4070504@rtr.ca \
--to=liml@rtr.ca \
--cc=buytenh@wantstofly.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=nico@cam.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.