From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
David Reiss <dreiss@facebook.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Add support for GIT_CEILING_DIRS
Date: Wed, 14 May 2008 12:23:04 +0200 [thread overview]
Message-ID: <482ABD88.30103@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0805140903560.30431@racer>
Johannes Schindelin schrieb:
> On Tue, 13 May 2008, David Reiss wrote:
>> diff --git a/setup.c b/setup.c
>> index c54f2b6..d7d986c 100644
>> --- a/setup.c
>> +++ b/setup.c
>> @@ -359,10 +359,11 @@ const char *read_gitfile_gently(const char *path)
>> const char *setup_git_directory_gently(int *nongit_ok)
>> {
>> const char *work_tree_env = getenv(GIT_WORK_TREE_ENVIRONMENT);
>> + const char *env_ceiling_dirs = getenv(CEILING_DIRS_ENVIRONMENT);
>> static char cwd[PATH_MAX+1];
>> const char *gitdirenv;
>> const char *gitfile_dir;
>> - int len, offset;
>> + int len, offset, min_offset = -1;
>
> AFAIR we have min_offset in the mingw branch, too, but I think it is
> initialized to 0.
Yes, indeed, and even for much the same purpose (i.e. to stop before the
beginning of the path is reached - on Windows we don't want to look at
"C:" prefixes). Please look at this commit:
http://repo.or.cz/w/git/mingw/j6t.git?a=commitdiff;h=4ab30965f520bd444f3eefe1dee4622181933f90
-- Hannes
next prev parent reply other threads:[~2008-05-14 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 5:46 [PATCH 2/2] Add support for GIT_CEILING_DIRS David Reiss
2008-05-14 8:23 ` Johannes Schindelin
2008-05-14 10:23 ` Johannes Sixt [this message]
2008-05-14 16:51 ` Kevin Ballard
2008-05-14 17:02 ` Johannes Schindelin
2008-05-14 17:07 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482ABD88.30103@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=dreiss@facebook.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.