Re: [PATCH 2/3] N810: Don't export camera orientation

[Sakari Ailus <sakari.ailus@nokia.com>]

ext Felipe Balbi wrote:

Hello Felipe, and thanks for reviewing the patch! :)

> On Tue, 13 May 2008 19:04:22 +0300, Sakari Ailus <sakari.ailus@nokia.com>
> wrote:
>> @@ -298,12 +340,21 @@ static int tcm825x_ifparm(struct v4l2_ifparm *p)
>>  	return 0;
>>  }
>>
>> +static int tcm825x_is_upside_down(void)
>> +{
>> +	if (machine_is_nokia_n810())
>> +		return 1;
>> +
>> +	return 0;
>> +}
>> +
>>  const struct tcm825x_platform_data n800_tcm825x_platform_data = {
>> -	.is_okay      = tcm825x_is_okay,
>> -	.power_set    = tcm825x_power_set,
>> -	.default_regs = tcm825x_default_regs,
>> -	.needs_reset  = tcm825x_needs_reset,
>> -	.ifparm	      = tcm825x_ifparm,
>> +	.is_okay	= tcm825x_is_okay,
>> +	.power_set	= tcm825x_power_set,
>> +	.default_regs	= tcm825x_default_regs,
>> +	.needs_reset	= tcm825x_needs_reset,
>> +	.ifparm		= tcm825x_ifparm,
>> +	.is_upside_down	= tcm825x_is_upside_down,
> 
> ok, now i got your point but this could be:
> .is_upside_down = machine_is_nokia_n810() ? 1 : 0,

This doesn't work because machine_is_nokia_n810() is not constant.

Anyway, tcm825x_is_upside_down can be made more simple as it could just 
return machine_is_nokia_n810().

I'll send new patches.

-- 
Sakari Ailus
sakari.ailus@nokia.com