From: Paulo Marques <pmarques@grupopie.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kallsyms: fix potential overflow in binary search
Date: Wed, 14 May 2008 15:24:15 +0100 [thread overview]
Message-ID: <482AF60F.5050002@grupopie.com> (raw)
In-Reply-To: <84144f020805140522m6136ff69w7ffa6f9c9248706f@mail.gmail.com>
Pekka Enberg wrote:
> On Wed, May 14, 2008 at 2:44 PM, Paulo Marques <pmarques@grupopie.com> wrote:
>>> This will probably never trigger... but it won't hurt to be careful.
>> Not "probably", this will never trigger _period_. If you ever have more
>> than 2^31 symbols in the kernel's kallsyms table you'll have worse problems
>> to worry about than the binary search overflowing.
>>
>> So, I don't think it is worth this des-optimization at all...
>
> Yes it is. It serves as correct reference code and the
> "deoptimization" is not measurable.
Hum? "reference code"? in the middle of a kallsyms function?
And are you really worried about contiguous arrays that are bigger than
2^31 elements? What kind of kernel structure would that be?
The fact that the "deoptimization" isn't measurable isn't an excuse for
unnecessary bloat.
This all seems like a wild goose chase to me...
--
Paulo Marques - www.grupopie.com
"To be, or not to be? That is ..... liable to be removed at -O2 and above."
next prev parent reply other threads:[~2008-05-14 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 20:07 [PATCH] kallsyms: fix potential overflow in binary search Vegard Nossum
2008-05-14 11:44 ` Paulo Marques
2008-05-14 12:22 ` Pekka Enberg
2008-05-14 14:24 ` Paulo Marques [this message]
2008-05-14 15:31 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482AF60F.5050002@grupopie.com \
--to=pmarques@grupopie.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.