From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pat Campbell <plc@novell.com>
Subject: Re: [PATCH] qemu: Send unit_attention on cd-rom not_ready
	to ready transition
Date: Wed, 14 May 2008 11:37:14 -0600
Message-ID: <482B234A.6@novell.com>
References: <4829D68E.9060802@novell.com>
	<18474.44630.496692.496664@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <18474.44630.496692.496664@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Ian Jackson wrote:
> Pat Campbell writes ("[Xen-devel][PATCH] qemu: Send unit_attention on cd-rom not_ready to ready transition"):
>   
>> Patch sends a UNIT_ATTENTION(6), MEDIUM_MAY_HAVE_CHANGED(0x28) sense
>> when cdrom transitions from not ready to ready. 
>>     
>
> It seems to me that this patch should go upstream to qemu.
> Is there some reason why not ?
>   
Submitted upstream to qemu this morning.
> If it should, please prepare a version of it against qemu CVS head and
> submit it to the qemu list (qemu-devel@nongnu.org).  I'll keep an eye
> on it there too, as the qemu guys are quite busy and have a tendency
> to overlook things so a reminder can be necessary.
>
> in general it would be helpful if contributors helped keep to a
> minimum the non-Xen-specific changes to ioemu.  For larger patches
> which need to vary substantially because of the existing differences
> between upstream and ioemu, it's probably easier for someone who knows
> those differences (eg, me) to do this.  But I think that at least for
> a small independent change like this it would be good for patch
> submitters to talk to upstream as well as us.
>
> I haven't double-checked the ATA spec but your patch looks reasonable
> for xen-unstable, anyway.
>
> Thanks,
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>