From: Kevin Wolf <kwolf@suse.de>
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: "Li, Haicheng" <haicheng.li@intel.com>,
xen-devel@lists.xensource.com,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: VMX status report. Xen: #17630 & Xen0: #540 -- blocked
Date: Thu, 15 May 2008 11:50:09 +0200 [thread overview]
Message-ID: <482C0751.5000703@suse.de> (raw)
In-Reply-To: <FF386CB4AE0E4648B0A96060EC00F36CA72230@pdsmsx412.ccr.corp.intel.com>
Xu, Dongxiao schrieb:
> I just tried your patch, and seems that it doesn't work.
> Actually, find_protocol() could not find out the qcow protocol, and for qcow image, that function will always return NULL after C/S 17606. I think this is the root cause why qcow image could not be booted.
find_protocol isn't even responsible for finding out that it's qcow.
There is a difference between image format and protocol (IIRC, the
latter is used in qemu for things like vvfat which maps a host directory
to a virtual FAT floppy/harddisk). I suspect the problem arises from the
bdrv_file_open call in find_image_format which won't correctly get
&bdrv_raw but NULL as driver.
And you're right, the patch can't work. I missed that in bdrv_open2 for
BDRV_O_FILE drv is ignored and always overwritten.
Kevin
next prev parent reply other threads:[~2008-05-15 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 9:50 VMX status report. Xen: #17630 & Xen0: #540 -- blocked Li, Haicheng
2008-05-14 10:44 ` Ian Jackson
2008-05-15 7:40 ` Li, Haicheng
2008-05-15 8:30 ` Xu, Dongxiao
2008-05-15 9:00 ` Kevin Wolf
2008-05-15 9:31 ` Xu, Dongxiao
2008-05-15 9:50 ` Kevin Wolf [this message]
2008-05-15 11:07 ` Ian Jackson
2008-05-15 11:54 ` Kevin Wolf
2008-05-15 13:07 ` Ian Jackson
2008-05-15 13:53 ` Kevin Wolf
2008-05-16 1:38 ` Xu, Dongxiao
2008-05-16 9:14 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482C0751.5000703@suse.de \
--to=kwolf@suse.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dongxiao.xu@intel.com \
--cc=haicheng.li@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.