All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Guyader <jean.guyader@eu.citrix.com>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>,
	Jean Guyader <jean.guyader@eu.citrix.com>,
	xen-devel@lists.xensource.com,
	Ian Pratt <Ian.Pratt@eu.citrix.com>, Keir Fraser <keir.fra>
Subject: Re: [PATCH] Pass-through a graphic card
Date: Thu, 15 May 2008 12:17:50 +0100	[thread overview]
Message-ID: <482C1BDE.9060107@eu.citrix.com> (raw)
In-Reply-To: <20080515111323.GE5689@implementation.bordeaux.inria.fr>

Samuel Thibault wrote:
> Jean Guyader, le Thu 15 May 2008 11:11:10 +0100, a écrit :
>>  
>> +int get_vga_pt_enabled(void)
>> +{
>> +    struct hvm_info_table *t = get_hvm_info_table();
>> +    return (t && t->vga_bios_paddr > 0);
>> +}
>> +
>> +int get_vga_pt_bios_paddr(void)
>> +{
>> +    struct hvm_info_table *t = get_hvm_info_table();
>> +    return (t ? t->vga_bios_paddr : 0);
>> +}
>> +
>> +int get_vga_pt_bios_size(void)
>> +{
>> +    struct hvm_info_table *t = get_hvm_info_table();
>> +    return (t ? t->vga_bios_size : -1);
>> +}
>> +
> 
> Mmm, maybe enabled and bios_size are redundant, since bios_size > 0
> implies enabled?
> 

Yes, but it doesn't really matter. I am rewriting the patch to not use 
this thing any more.

-- 
Jean Guyader

  reply	other threads:[~2008-05-15 11:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09 11:11 [PATCH] Pass-through a graphic card Jean Guyader
2008-05-09 11:18 ` Jean Guyader
2008-05-09 11:32   ` Samuel Thibault
2008-05-09 11:27 ` Samuel Thibault
2008-05-09 13:56 ` Jean Guyader
2008-05-09 14:02   ` Daniel P. Berrange
2008-05-09 14:25   ` Daniel P. Berrange
2008-05-09 15:47     ` Jean Guyader
2008-05-15 10:11 ` Jean Guyader
2008-05-15 11:13   ` Samuel Thibault
2008-05-15 11:17     ` Jean Guyader [this message]
2008-05-16  8:59       ` Jean Guyader
2008-05-16 17:15         ` Samuel Thibault
  -- strict thread matches above, loose matches on Subject: below --
2008-06-13 15:08 mail mark
2008-06-13 15:25 ` Jean Guyader
2008-06-21 17:36   ` mail mark
2008-06-21 19:28     ` Jean Guyader
2008-06-23 13:20       ` mail mark
2008-06-21 17:43   ` Neo Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482C1BDE.9060107@eu.citrix.com \
    --to=jean.guyader@eu.citrix.com \
    --cc=Ian.Pratt@eu.citrix.com \
    --cc=samuel.thibault@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.