From: Jan Kiszka <jan.kiszka@siemens.com>
To: kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: [PATCH] Remove unused get_bios_map
Date: Thu, 15 May 2008 15:05:10 +0200 [thread overview]
Message-ID: <482C3506.4010000@siemens.com> (raw)
Dead code since it was introduced. Is it planned to use it in the near
future? Then I would suggest to put it under #if 0 for now. Otherwise,
please pick up this patch.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
qemu/kvm-tpr-opt.c | 13 -------------
1 file changed, 13 deletions(-)
Index: b/qemu/kvm-tpr-opt.c
===================================================================
--- a/qemu/kvm-tpr-opt.c
+++ b/qemu/kvm-tpr-opt.c
@@ -83,19 +83,6 @@ static void write_byte_virt(CPUState *en
stb_phys(map_addr(&sregs, virt, NULL), b);
}
-static uint32_t get_bios_map(CPUState *env, unsigned *perms)
-{
- uint32_t v;
- struct kvm_sregs sregs;
-
- kvm_get_sregs(kvm_context, env->cpu_index, &sregs);
-
- for (v = -4096u; v != 0; v -= 4096)
- if (map_addr(&sregs, v, perms) == 0xe0000)
- return v;
- return -1u;
-}
-
struct vapic_bios {
char signature[8];
uint32_t virt_base;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next reply other threads:[~2008-05-15 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 13:05 Jan Kiszka [this message]
2008-05-19 10:19 ` [kvm-devel] [PATCH] Remove unused get_bios_map Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482C3506.4010000@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.