From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration
Date: Thu, 15 May 2008 17:26:08 -0500 [thread overview]
Message-ID: <482CB880.6050300@freescale.com> (raw)
In-Reply-To: <20080515222212.1005F247A5@gemini.denx.de>
Wolfgang Denk wrote:
> In message <1210886469.880.45.camel@laptop> you wrote:
>>> Please also remove the default MAC address assignments.
>> I think we need them, don't we?
>
> No, or you can install this U-Boot image exactly on one specific,
> single board.
I understand your argument, but it's rather disingenuous when you allow this
code to exist:
#ifdef CONFIG_ETHADDR
"ethaddr=" MK_STR(CONFIG_ETHADDR) "\0"
#endif
#ifdef CONFIG_ETH1ADDR
"eth1addr=" MK_STR(CONFIG_ETH1ADDR) "\0"
#endif
#ifdef CONFIG_ETH2ADDR
"eth2addr=" MK_STR(CONFIG_ETH2ADDR) "\0"
#endif
#ifdef CONFIG_ETH3ADDR
"eth3addr=" MK_STR(CONFIG_ETH3ADDR) "\0"
#endif
#ifdef CONFIG_IPADDR
"ipaddr=" MK_STR(CONFIG_IPADDR) "\0"
#endif
#ifdef CONFIG_SERVERIP
"serverip=" MK_STR(CONFIG_SERVERIP) "\0"
#endif
If you get rid of this block, you'll solve the problem for all boards, instead
of nagging people who post patches for unrelated bugs.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-05-15 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 20:26 [U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration York Sun
2008-05-15 20:50 ` Ben Warren
2008-05-15 21:21 ` York Sun
2008-05-15 22:11 ` Ben Warren
2008-05-15 22:22 ` Wolfgang Denk
2008-05-15 22:26 ` Timur Tabi [this message]
2008-05-15 22:41 ` Wolfgang Denk
2008-05-15 22:43 ` Timur Tabi
2008-05-15 23:06 ` Wolfgang Denk
2008-05-15 23:10 ` Timur Tabi
2008-05-16 0:25 ` Ben Warren
2008-05-19 21:01 ` Wolfgang Denk
2008-05-19 21:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482CB880.6050300@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.