Re: barriers off by default?

[Eric Sandeen <sandeen@redhat.com>]

Jan Kara wrote:
> On Thu 15-05-08 15:44:04, Eric Sandeen wrote:


>> +	if (!test_opt(sb, BARRIER)) {
>> +		seq_puts(seq, ",barrier=0");
>> +	} else {
>> +		/*
>> +	 	* jbd inherits the barrier flag from ext3, and jbd may actually
>> +	 	* turn off barriers if a write fails, so it's the real test.
>> +	 	*/
>> +		if (journal && !(journal->j_flags & JFS_BARRIER))
>> +			seq_puts(seq, ",barrier=1(failed)");
>> +	}

Actually, since /proc/mounts should substitute for mtab I should not be
putting chatty informational messages in there, should I!

        /*
         * jbd inherits the barrier flag from ext3, and jbd may actually
         * turn off barriers if a write fails, so it's the real test.
         */
        if (!test_opt(sb, BARRIER) ||
            (journal && !(journal->j_flags & JFS_BARRIER)))
                seq_puts(seq, ",barrier=0");

is a better plan.

-Eric