All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jack Steiner <steiner@sgi.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, "Huang,
	Ying" <ying.huang@intel.com>, Andi Kleen <andi@firstfloor.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/10] x86 boot: include missing smp.h header
Date: Fri, 16 May 2008 06:20:13 -0700	[thread overview]
Message-ID: <482D8A0D.7020902@sgi.com> (raw)
In-Reply-To: <20080514151504.148486.32236.sendpatchset@jackhammer.engr.sgi.com>

Acked-By: Mike Travis <travis@sgi.com>

Paul Jackson wrote:
> From: Paul Jackson <pj@sgi.com>
> 
> The patch:
>     x86: convert cpu_to_apicid to be a per cpu variable
> introduced a dependency of ipi.h on smp.h in x86
> builds with an allnoconfig.  Including smp.h in ipi.h
> fixes the build error:
>     In file included from arch/x86/kernel/traps_64.c:48:
>     include/asm/ipi.h: In function 'send_IPI_mask_sequence':
>     include/asm/ipi.h:114: error: 'per_cpu__x86_cpu_to_apicid' undeclared (first use in this function)
> 
> Signed-off-by: Paul Jackson <pj@sgi.com>
> Cc: Mike Travis <travis@sgi.com>
> 
> ---
>  include/asm-x86/ipi.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux.orig/include/asm-x86/ipi.h	2008-05-13 10:44:39.000000000 -0700
> +++ linux/include/asm-x86/ipi.h	2008-05-13 10:56:37.431506774 -0700
> @@ -20,6 +20,7 @@
>  
>  #include <asm/hw_irq.h>
>  #include <asm/apic.h>
> +#include <asm/smp.h>
>  
>  /*
>   * the following functions deal with sending IPIs between CPUs.
> 


      parent reply	other threads:[~2008-05-16 13:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-14 15:15 [PATCH 1/10] x86 boot: include missing smp.h header Paul Jackson
2008-05-14 15:15 ` [PATCH 2/10] x86 boot: remove some unused extern function declarations Paul Jackson
2008-05-14 15:15 ` [PATCH 3/10] x86 boot: add header comment to dmi.h stating what it is Paul Jackson
2008-05-14 15:15 ` [PATCH 4/10] x86 boot: simplify pageblock_bits enum declaration Paul Jackson
2008-05-14 15:15 ` [PATCH 5/10] x86 boot: minor code format fixes in e820 and efi routines Paul Jackson
2008-05-14 15:15 ` [PATCH 6/10] x86 boot: proper use of ARRAY_SIZE instead of repeated E820MAX constant Paul Jackson
2008-05-14 15:15 ` [PATCH 7/10] x86 boot: extend some internal memory map arrays to handle larger EFI input Paul Jackson
2008-05-14 15:15 ` [PATCH 8/10] x86 boot: change sanitize_e820_map parameter from byte to int to allow bigger memory maps Paul Jackson
2008-05-14 15:15 ` [PATCH 9/10] x86 boot: longer comment explaining sanitize_e820_map routine Paul Jackson
2008-05-14 15:15 ` [PATCH 10/10] x86 boot: add code to add BIOS provided EFI memory entries to kernel Paul Jackson
2008-05-16  0:03   ` Paul Jackson
2008-05-16 12:38     ` Ingo Molnar
2008-05-16 16:30       ` Paul Jackson
2008-05-18  6:49       ` Paul Jackson
2008-05-19 16:10         ` Ingo Molnar
2008-05-27  3:12   ` Huang, Ying
2008-05-27 19:08     ` Paul Jackson
2008-05-27 19:16       ` H. Peter Anvin
2008-05-28  9:59         ` Paul Jackson
2008-05-16 13:20 ` Mike Travis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482D8A0D.7020902@sgi.com \
    --to=travis@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pj@sgi.com \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.