Re: [Qemu-devel] Use of PATH_MAX

[Anthony Liguori <anthony@codemonkey.ws>]

Ian Jackson wrote:
> iwj writes ("Re: [Qemu-devel] Use of PATH_MAX"):
>   
>> I agree that it would be better to get rid of the static buffers.  But
>> at the moment I'm just trying to stop a tide of PATH_MAX nonsense
>> enveloping the Xen semi-fork.  [...]
>>     
>
> Sorry, let me be clearer: in the Xen version of qemu, which I'm trying
> to bring more into line with upstream, people are seeing PATH_MAX in
> some places and changing fixed constants 1024 to PATH_MAX because they
> think that PATH_MAX is the right thing to do.
>
> If I can get agreement on a new name to use in qemu proper then it
> will be easy to change to use that everywhere.
>
> Of course if someone wants to do the work to make the buffers dynamic
> then that is good but that's quite a bit of work and is likely to
> introduce the occasional memory management bug, so I don't think that
> changing 1024 and PATH_MAX to QEMU_PATH_MAX should wait for it.
>   

I don't see any value in converting PATH_MAX to QEMU_PATH_MAX.

Both are equally wrong.

Regards,

Anthony Liguori

> Ian.
>
>
>