From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jx6Mk-0006KQ-Jk for mharc-grub-devel@gnu.org; Fri, 16 May 2008 16:17:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jx6Mi-0006K9-LG for grub-devel@gnu.org; Fri, 16 May 2008 16:17:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jx6Mg-0006JZ-LT for grub-devel@gnu.org; Fri, 16 May 2008 16:17:20 -0400 Received: from [199.232.76.173] (port=39767 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx6Mg-0006JV-Cg for grub-devel@gnu.org; Fri, 16 May 2008 16:17:18 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:52032 helo=jenni2.rokki.sonera.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jx6Mf-0004PD-Br for grub-devel@gnu.org; Fri, 16 May 2008 16:17:18 -0400 Received: from [127.0.0.1] (88.193.32.97) by jenni2.rokki.sonera.fi (8.5.014) id 482C7F34000EAB58 for grub-devel@gnu.org; Fri, 16 May 2008 23:17:16 +0300 Message-ID: <482DEBD3.6050002@nic.fi> Date: Fri, 16 May 2008 23:17:23 +0300 From: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: The development of GRUB 2 References: <1209647545.3433.14.camel@localhost.localdomain> <1210148236.2773.95.camel@localhost.localdomain> In-Reply-To: <1210148236.2773.95.camel@localhost.localdomain> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: Quoted-Printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] GDB stuff updated X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2008 20:17:21 -0000 Hi Lubomir, Lubomir Rintel wrote: > Updated GDB stub patch, just header text changes, changelog text fix an= d > stripped of junk. >=20 > Also -- solved the mystery of the dl.c fix; for some reason I managed t= o > generate a reversed diff. It is required to link the gdb module (symbol= s > defined with =EF=BB=BF.globl in assembler sources, IIRC) >=20 > I am not going to attach all the patches here. > All that's needed is here [1]: Are those copyright years correct or result of copy paste error? Most of=20 the files in this patch are new to GRUB 2 repository. > grub2-dlsym-v4.patch I am not big fan of fallthru's in switches. They can easily lead to=20 programming errors. As code is rather short and I assume compiler will=20 optimize it anyway, could you just make clean case for STT_NOTYPE=20 without fallthru. > grub2-gdb-macros-v4.patch Should those be stored on folder like: contrib/gdb/ > grub2-gdb-stub-v4.patch Do we want to support other communication mechanism than serial in=20 future for GDB ? I am asking this because it could be prepared a bit=20 with proper interfaces. That would also make code a bit more tidier. +++ grub2-gdb/gdb/cstub.c 2008-05-07 10:15:52.000000000 +0200 +int (*grub_gdb_getchar) (); Add void. Perhaps you could make typedef for it and declaring variable=20 as static? +static int +hex (ch) + char ch; +{ Let's be a bit more modern... grub_gdb_getpacket (void): It may be good idea to refer to documentation stating framing structure=20 or adding comment about frame. +++ grub2-gdb/gdb/gdb.c 2008-05-07 09:39:11.000000000 +0200 I do not really like this explicit attachment to serial device. Perhaps=20 we should improve serial module and then make gdb to have communication=20 interface. +++ grub2-gdb/gdb/i386/idt.c 2008-05-07 09:39:11.000000000 +0200 Why not move this as own functional block to: kern/i386/ Also removing trace for gdb :) I think we need IDT for other features being planned. +++ grub2-gdb/gdb/i386/machdep.S 2008-05-07 09:39:11.000000000 +0200 We do not do bunnies... grub_idt_load: Why not move this to startup.S. +++ grub2-gdb/include/grub/i386/gdb.h 2008-05-07 09:39:11.000000000 +0200 Seperate IDT stuff.. +++ grub2-gdb/include/grub/i386/pc/kernel.h 2008-05-07=20 09:39:11.000000000 +0200 +#define GRUB_KERNEL_MACHINE_RAW_SIZE 0x4BC Ok... this has to be automated... lets see... +++ grub2-gdb/kern/i386/pc/startup.S 2008-05-07 09:39:11.000000000 +0200 How about raving readmode IDT (or IDT what we started with) so we can=20 recall it when we are calling BIOS services... just in case. +++ grub2-gdb/term/i386/pc/serial.c 2008-05-07 09:39:11.000000000 +0200 Not really happy about this change. Lets try to figure out better=20 interface... > grub2-preserve-symbols-v4.patch Ok... Needs fine tuning for changelog entry, but otherwise fine. >=20 > [1] http://fedorapeople.org/~lkundrak/grub2/ >=20 I hope those keep you busy for a while :) Thanks, Vesa J=C3=A4=C3=A4skel=C3=A4inen