All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] abituguru probe failure
Date: Fri, 16 May 2008 22:20:36 +0000	[thread overview]
Message-ID: <482E08B4.2090706@hhs.nl> (raw)
In-Reply-To: <200805162307.28224.alistair@devzero.co.uk>

Alistair John Strachan wrote:
> Hi,
> 
> I have an IP35 Pro mainboard with the uGuru feature. Until recently I was
> using the abituguru hwmon driver without issue. Recently (possibly since
> upgrading the BIOS to 16) the driver no longer loads, citing:
> 
> abituguru3: no Abit uGuru3 found, data = 0x00, cmd = 0x55
> 
> After looking at the code in the driver, I found the force module parameter
> and tried it. Sure enough, the module loaded fine:
> 

<snip>

> A fix that works here is to add 0x55 as an additional cmd_val check in
> abituguru3_detect(), but I think we all know this function is starting to
> look a bit suspicious. I've attached a patch which does this (tested as
> working), but I won't be surprised if you guys don't want to apply it.
> 

Well I'm afraid that even though that makes the detection rather weak it is 
still the best thing todo, having to use force with a newer BIOS is no good.

I guess that to limit any potential issues we can best first do a DMI based 
check to see if this is an Abit motherboard at all before doing any IO based 
probing, just like we are already doing for the abituguru (note no 3) driver.

Alistair, can you send me the output of the dmidecode command on your 
motherboard, I need that to make sure Abit hasn't changed their DMi 
manufacturer string on newer motherboards.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2008-05-16 22:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16 22:07 [lm-sensors] abituguru probe failure Alistair John Strachan
2008-05-16 22:18 ` Alistair John Strachan
2008-05-16 22:20 ` Hans de Goede [this message]
2008-05-17 12:46 ` Alistair John Strachan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482E08B4.2090706@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.