All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/5] x86: Move es7000_plat out of mpparse.c
Date: Sat, 17 May 2008 03:31:33 +0400	[thread overview]
Message-ID: <482E1955.8080506@suse.de> (raw)
In-Reply-To: <20080516130422.GA24607@elte.hu>

Ingo,
I seem to have lost the track of changes... Why the ifdef LOCAL_APIC was 
switched to MPPARSE?

Reverting it back makes the error to go away...

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 089ddfa..c86bda7 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -12,7 +12,7 @@
 #include <asm/mpspec.h>
 #include <asm/apicdef.h>
 
-#ifdef CONFIG_X86_MPPARSE
+#ifdef CONFIG_X86_LOCAL_APIC
 unsigned int num_processors;
 unsigned disabled_cpus __cpuinitdata;


Ingo Molnar wrote:
> the build failure is:
> 
> arch/x86/kernel/built-in.o: In function `init_apic_mappings':
> : undefined reference to `boot_cpu_physical_apicid'
> arch/x86/kernel/built-in.o: In function `init_apic_mappings':
> : undefined reference to `boot_cpu_physical_apicid'
> arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
> : undefined reference to `boot_cpu_physical_apicid'
> arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
> : undefined reference to `boot_cpu_physical_apicid'
> arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
> : undefined reference to `phys_cpu_present_map'
> arch/x86/kernel/built-in.o: In function `setup_local_APIC':
> : undefined reference to `phys_cpu_present_map'
> arch/x86/kernel/built-in.o: In function `generic_processor_info':
> : undefined reference to `phys_cpu_present_map'
> arch/x86/kernel/built-in.o: In function `generic_processor_info':
> : undefined reference to `num_processors'
> arch/x86/kernel/built-in.o: In function `generic_processor_info':
> : undefined reference to `num_processors'
> arch/x86/mach-visws/built-in.o: In function `find_smp_config':
> : undefined reference to `boot_cpu_physical_apicid'
> arch/x86/mach-visws/built-in.o: In function `find_smp_config':
> : undefined reference to `phys_cpu_present_map'
> 


  reply	other threads:[~2008-05-16 23:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-14 15:02 [PATCH 1/5] x86: Move es7000_plat out of mpparse.c Alexey Starikovskiy
2008-05-14 15:02 ` [PATCH 2/5] x86: complete move ACPI from mpparse.c Alexey Starikovskiy
2008-05-14 15:03 ` [PATCH 3/5] x86: make mp_ioapic_routing definition local Alexey Starikovskiy
2008-05-14 15:03 ` [PATCH 4/5] x86: make struct config_ioapic not MPspec specific Alexey Starikovskiy
2008-05-14 15:03 ` [PATCH 5/5] x86: make config_irqsrc " Alexey Starikovskiy
2008-05-16 12:43 ` [PATCH 1/5] x86: Move es7000_plat out of mpparse.c Ingo Molnar
2008-05-16 13:03   ` Ingo Molnar
2008-05-16 13:04     ` Ingo Molnar
2008-05-16 23:31       ` Alexey Starikovskiy [this message]
2008-05-19 12:23         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482E1955.8080506@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.