All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: Tejun Heo <htejun@gmail.com>, Alan Cox <alan@redhat.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 05/09] sata_mv don't blindly enable IRQs
Date: Sat, 17 May 2008 13:41:50 -0400	[thread overview]
Message-ID: <482F18DE.2090102@pobox.com> (raw)
In-Reply-To: <482F1732.6010109@rtr.ca>

Mark Lord wrote:
> These five small patches are on top of the four previously posted,
> so I'm extending the numbering to be xx/09 now:
> 
> -----snip-----
> 
> Part one of simplifying/fixing handling of the main_irq_mask register
> to resolve unexpected interrupt issues observed in 2.6.26-rc*.
> 
> Don't blindly enable port IRQs at host init time.
> Instead, enable only the bits that we want,
> which in this case is simply the PCI_ERR bit.
> 
> The per-port bits can wait until the ports are reset/probed for devices.
> 
> Signed-off-by: Mark Lord <mlord@pobox.com>

Two process notes for future use:

1) please include a colon (":") or other punctuation after "sata_mv" 
prefix in subject line.

2) when adding notes like "These five small patches...", we already have 
a method of doing so:  the "---" separator.  The format of the patch 
body should be:


	patch description for kernel changelog

	signed-off-by: ...
	---
	These five small patches are on top of the four previously
	posted, so I'm extending the numbering to be xx/09 now.


Both of these details are documented in Documentation/SubmittingPatches 
and http://linux.yyz.us/patch-format.html

OTOH, your numbering behavior -- extending the patch numbering as you've 
done here, when the first patchset is not yet applied to git -- is quite 
useful and should be emulated by others :)

Tejun sometimes simply posts a new patchseries, noting that that 
patchseries is dependent upon a previous series.  That's fine, too.

Thanks,

	Jeff




  parent reply	other threads:[~2008-05-17 17:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-14 13:18 [PATCH 01/04] sata_mv always do softreset Mark Lord
2008-05-14 13:19 ` [PATCH 02/04] sata_mv fis irq register fixes Mark Lord
2008-05-14 13:21   ` [PATCH 03/04] sata_mv group genIIe flags Mark Lord
2008-05-14 13:24     ` [PATCH 04/04] sata_mv async notify for genIIe only Mark Lord
2008-05-17 17:34       ` [PATCH 05/09] sata_mv don't blindly enable IRQs Mark Lord
2008-05-17 17:35         ` [PATCH 06/09] sata_mv consolidate main_irq_mask updates Mark Lord
2008-05-17 17:36           ` [PATCH 07/09] sata_mv fix pmp drives not found Mark Lord
2008-05-17 17:37             ` [PATCH 08/09] sata_mv disregard masked irqs Mark Lord
2008-05-17 17:38               ` [PATCH 09/09] sata_mv cache main_irq_mask register in hpriv Mark Lord
2008-05-19 13:01                 ` [PATCH 10/10] sata_mv: ensure empty request queue for FBS-NCQ EH Mark Lord
2008-05-19 21:41                   ` Jeff Garzik
2008-05-19 21:42                   ` Jeff Garzik
2008-05-19 18:27                 ` [PATCH 09/09] sata_mv cache main_irq_mask register in hpriv Grant Grundler
2008-05-17 17:41         ` Jeff Garzik [this message]
2008-05-17 17:45           ` [PATCH 05/09] sata_mv don't blindly enable IRQs Mark Lord
2008-05-17 17:49             ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482F18DE.2090102@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=alan@redhat.com \
    --cc=htejun@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.