From: Patrick McHardy <kaber@trash.net>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
devzero@web.de, Robert Olsson <robert.olsson@its.uu.se>,
Pavel Emelyanov <xemul@openvz.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ben Greear <greearb@candelatech.com>
Subject: Re: [Bugme-new] [Bug 10737] New: pktgen procfs problem
Date: Mon, 19 May 2008 12:34:55 +0200 [thread overview]
Message-ID: <483157CF.5080201@trash.net> (raw)
In-Reply-To: <1211183642.9966.6.camel@iris.sw.ru>
Denis V. Lunev wrote:
> On Sun, 2008-05-18 at 17:31 +0200, Patrick McHardy wrote:
>
>> git-bisect identified e9720acd ([NET]: Make /proc/net a symlink
>> on /proc/self/net (v3)) as the guilty commit. I couldn't find
>> the problem in that commit, so someone with a better understanding
>> of how this is supposed to work should look into it.
>>
>
> could you consider this preliminary patch? It fixes the problem for me
> and Pavel agrees with it.
>
> The problem is that module_get is called for each file opening while
> module_put is called only when /proc inode is destroyed. So, lets put
> module counter if we are dealing with already initialised inode.
>
The patch works fine for me, thanks.
next prev parent reply other threads:[~2008-05-19 10:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10737-10286@http.bugzilla.kernel.org/>
2008-05-17 21:10 ` [Bugme-new] [Bug 10737] New: pktgen procfs problem Andrew Morton
2008-05-18 1:39 ` Patrick McHardy
2008-05-18 4:56 ` Andrew Morton
2008-05-18 12:06 ` Patrick McHardy
2008-05-18 13:24 ` Patrick McHardy
2008-05-18 15:31 ` Patrick McHardy
2008-05-19 7:54 ` Denis V. Lunev
2008-05-19 10:34 ` Patrick McHardy [this message]
2008-05-20 0:26 ` Ben Greear
2008-05-20 1:14 ` Eric W. Biederman
2008-05-20 8:25 ` Robert Olsson
2008-05-19 21:34 ` Eric W. Biederman
2008-05-19 22:19 ` Ben Greear
2008-05-19 15:19 Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2008-05-19 16:03 Alexey Dobriyan
2008-05-19 22:21 Alexey Dobriyan
2008-05-19 22:45 ` Robert Olsson
2008-05-20 21:57 Alexey Dobriyan
2008-05-20 21:17 ` Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483157CF.5080201@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=den@openvz.org \
--cc=devzero@web.de \
--cc=ebiederm@xmission.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.