Edgar E. Iglesias wrote:
> On Thu, May 15, 2008 at 09:11:30AM -0500, Jason Wessel wrote:
>   
>> This patch adds a feature to the gdbstub to allow gdb to issue monitor
>> commands that can pass-through to the qemu monitor.
>>
>>     
>>  
>> +static void monitor_output(GDBState *s, const char *msg)
>> +{
>> +    monitor_output_len(s, msg, 0);
>> +}
>> +
>>     
>
>
> If you change the zero argument into a strlen(msg) you can drop the check in monitor_output_len().
>
>
>   

Sure.  That seems reasonable.

>>  static void monitor_help(GDBState *s)
>>  {
>>      monitor_output(s, "gdbstub specific monitor commands:\n");
>> @@ -258,6 +267,7 @@ static void monitor_help(GDBState *s)
>>      monitor_output(s, "set s_step <0|1> -- Single Stepping enabled\n");
>>      monitor_output(s, "set s_irq <0|1> --  Single Stepping with qemu irq handlers enabled\n");
>>      monitor_output(s, "set s_timer <0|1> -- Single Stepping with qemu timers enabled\n");
>> +    monitor_output(s, "qemu monitor pass-through commands:\n");
>>  }
>>     
>
>   

Seems reasonable too, see newly attached patch.

Obviously you need the new monitor patch applied prior to this one. 
This patch was updated against the prior patch.

Thanks,
Jason.