From: Brice Goglin <brice@myri.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Gallatin <gallatin@myri.com>,
jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make myri10ge_get_firmware_capabilities() static
Date: Tue, 20 May 2008 07:52:24 +0200 [thread overview]
Message-ID: <48326718.90504@myri.com> (raw)
In-Reply-To: <20080519215300.GC17716@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> This patch makes the needlessly global
> myri10ge_get_firmware_capabilities() static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Acked-by: Brice Goglin <brice@myri.com>
> ---
> 0442d0c2cb767d312f5264cc226a1595c47f3dbf diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
> index c91b12e..36be6ef 100644
> --- a/drivers/net/myri10ge/myri10ge.c
> +++ b/drivers/net/myri10ge/myri10ge.c
> @@ -631,7 +631,7 @@ static int myri10ge_adopt_running_firmware(struct myri10ge_priv *mgp)
> return status;
> }
>
> -int myri10ge_get_firmware_capabilities(struct myri10ge_priv *mgp)
> +static int myri10ge_get_firmware_capabilities(struct myri10ge_priv *mgp)
> {
> struct myri10ge_cmd cmd;
> int status;
>
>
next prev parent reply other threads:[~2008-05-20 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 21:53 [2.6 patch] make myri10ge_get_firmware_capabilities() static Adrian Bunk
2008-05-20 5:52 ` Brice Goglin [this message]
2008-05-22 10:20 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48326718.90504@myri.com \
--to=brice@myri.com \
--cc=bunk@kernel.org \
--cc=gallatin@myri.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.