Re: [linux-dvb] Updated Mantis VP-2033 remote control patch for Manu's jusst.de Mantis branch

From: Roland Scheidegger <rscheidegger_lists@hispeed.ch>
To: Pauli Borodulin <pauli@borodulin.fi>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] Updated Mantis VP-2033 remote control patch for Manu's jusst.de Mantis branch
Date: Tue, 20 May 2008 14:05:17 +0200	[thread overview]
Message-ID: <4832BE7D.2080808@hispeed.ch> (raw)
In-Reply-To: <48326CC4.7010401@borodulin.fi>

On 20.05.2008 08:16, Pauli Borodulin wrote:
>> On 19.05.2008 20:51, Pauli Borodulin wrote:
>  >> [...]
>>> What comes to auto-repeat... With your version of the patch it works 
>>> equally well/badly on 2033 as it did with the earlier version.
> 
> Roland Scheidegger wrote:
>> Just curious, what's the native repeat rate (what it prints out with
>> verbose set time between irqs) with this card?
> 
> Initial delay ~270ms and repeats ~220ms.
Ah so exactly the same as for my remote. Interesting...

> 
> Btw I found these in dvb-usb-remote.c:
> 
>      input_dev->rep[REP_PERIOD] = d->props.rc_interval;
>      input_dev->rep[REP_DELAY]  = d->props.rc_interval + 150;
> 
> So there seems to be some configurable auto-repeat functionality in 
> input layer. I guess I'll experiment with those even tho' RCs delays are 
> a bit crappy, since it's a pretty painful to go through a long list of 
> recordings without any auto-repeat...
If you change these values (to anything but zero) before
input_register_device, the input driver will just disable auto-repeat
(or rather, you'd need to handle it yourself in the driver with the
appropriate timer func, and I didn't feel like duplicating half the code
of the input driver). input_register_device also says all capabilities
must be set up before calling it, when I tried to change those values
afterwards it didn't seem to work (though maybe I made some testing
error, I can't see why it shouldn't work). I guess a REP_DELAY a bit
over the initial delay (like 300ms) should work, and a REP_PERIOD of
about 100 (which would give you about 50% chance of stopping pressing
keys exactly) might be reasonable - though it really is annoying if you
can't stop exactly (but it's not solvable - either live with slow repeat
or live with that).

Roland


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb