All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()
Date: Tue, 20 May 2008 14:47:32 +0200	[thread overview]
Message-ID: <4832C864.8020605@trash.net> (raw)
In-Reply-To: <1211285486.21380.204.camel@pmac.infradead.org>

David Woodhouse wrote:
> Am I just being particularly dim today, or can the call to
> dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
> happen?
> 
> We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
> condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
> true.

Thanks for catching this, you're correct of course.

  reply	other threads:[~2008-05-20 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 12:11 [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() David Woodhouse
2008-05-20 12:47 ` Patrick McHardy [this message]
2008-05-20 21:36   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4832C864.8020605@trash.net \
    --to=kaber@trash.net \
    --cc=dwmw2@infradead.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.