All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2/11] Add unlocked_fasync
Date: Tue, 20 May 2008 20:31:25 +0200	[thread overview]
Message-ID: <483318FD.5040506@firstfloor.org> (raw)
In-Reply-To: <27468.1211299125@vena.lwn.net>

Jonathan Corbet wrote:
> I guess my one concern with this mirrors what other people have said:
> might not it be better to just push the BKL down into the fasync()
> implementations and avoid adding yet another file operation?  A quick
> grep shows 43 drivers defining fasync() functions - and many of those
> use the same one.  fs/ has a few more.  Obnoxious but doable, unless
> there's something I'm missing?

See my reply to Arjan.  While for complicated stuff pushing down first
is better, fasync is not that complicated and I think my strategy
with the new entry point, with the old one going away is better in this
case.

-Andi


  reply	other threads:[~2008-05-20 18:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 15:28 [PATCH] [0/11] REPOST: Early exception fixes Andi Kleen
2008-05-20 15:28 ` [PATCH] [1/11] Remove BKL from remote_llseek v2 Andi Kleen
2008-05-20 15:28 ` [PATCH] [2/11] Add unlocked_fasync Andi Kleen
2008-05-20 15:58   ` Arjan van de Ven
2008-05-20 18:30     ` Andi Kleen
2008-05-20 20:06       ` Arjan van de Ven
2008-05-20 23:35         ` Andi Kleen
2008-05-21  4:47           ` Arjan van de Ven
2008-05-20 18:33     ` Alan Cox
2008-05-20 18:59       ` Andi Kleen
2008-05-20 15:58   ` Randy Dunlap
2008-05-20 15:58   ` Jonathan Corbet
2008-05-20 18:31     ` Andi Kleen [this message]
2008-05-20 15:28 ` [PATCH] [3/11] Convert pipe over to unlocked_fasync Andi Kleen
2008-05-20 15:28 ` [PATCH] [4/11] Convert socket fasync " Andi Kleen
2008-05-20 15:28 ` [PATCH] [5/11] Convert fuse " Andi Kleen
2008-05-20 15:28 ` [PATCH] [6/11] Convert bad_inode " Andi Kleen
2008-05-20 15:28 ` [PATCH] [7/11] Convert DRM " Andi Kleen
2008-05-21  6:36   ` Dave Airlie
2008-05-20 15:28 ` [PATCH] [8/11] Use unlocked_fasync in random.c Andi Kleen
2008-05-20 15:28 ` [PATCH] [9/11] Convert hpet to unlocked_fasync Andi Kleen
2008-05-21  9:01   ` Clemens Ladisch
2008-05-20 15:28 ` [PATCH] [10/11] Use unlocked_fasync in RTC Andi Kleen
2008-05-20 15:28 ` [PATCH] [11/11] Convert uio to fasync_unlocked Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2008-05-19 12:31 [PATCH] [0/11] Repost of old VFS BKL patchkit Andi Kleen
2008-05-19 12:31 ` [PATCH] [2/11] Add unlocked_fasync Andi Kleen
2008-05-19 14:03   ` Christoph Hellwig
2008-05-19 14:43     ` Andi Kleen
2008-05-19 15:12       ` Alan Cox
2008-05-19 15:29         ` Andi Kleen
2008-05-19 15:22           ` Alan Cox
2008-05-19 15:45             ` Andi Kleen
2008-05-19 17:29   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483318FD.5040506@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.