All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Big white-space cleanup.
Date: Wed, 21 May 2008 06:47:55 +0900	[thread overview]
Message-ID: <4833470B.6000904@ruby.dti.ne.jp> (raw)
In-Reply-To: <20080520205437.A2B08247A5@gemini.denx.de>

Wolfgang Denk wrote:
>> plus, it looks like the patch is replacing tabs with spaces (see, e.g.,
>> pib_init() changes in board/freescale/mpc8349emds/pci.c).
> 
> Hm... 

[snip]

> Argghhh.... No, really not. Thanks for cathing this one. It skipped
> both my automatic and manual verification :-(
> 
> 
> Patch version 2 available at 
> ftp://ftp.denx.de/pub/tmp/big-white-space-cleanup.patch-v.2.gz

I started to check some MIPS related file, and immediately found wrong
fixes.

    board/purple/purple.c ... cache_unroll
    cpu/mips/asc_serial.c ... TOUT_LOOP, FBS_ISR, many others!
    cpu/mips/start.S ... All tabs removed!!!
        :
        :
    [stop further review at this point]

Let me confirm whether above is intentional change or not, please?

I'm afraid it's better to leave them as they are, even if there are
silly white-space issues left.

  Shinya

  parent reply	other threads:[~2008-05-20 21:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 14:50 [U-Boot-Users] [PATCH] Big white-space cleanup Wolfgang Denk
2008-05-20 15:22 ` Kumar Gala
2008-05-20 18:44   ` Wolfgang Denk
2008-05-20 18:17 ` Kim Phillips
2008-05-20 20:54   ` Wolfgang Denk
2008-05-20 21:08     ` Kim Phillips
2008-05-20 21:39       ` Wolfgang Denk
2008-05-20 21:47     ` Shinya Kuribayashi [this message]
2008-05-20 22:21       ` Wolfgang Denk
2008-05-20 23:10 ` [U-Boot-Users] [PATCH-v3] " Wolfgang Denk
2008-05-20 23:58   ` Kim Phillips
2008-05-21  8:25     ` Wolfgang Denk
2008-05-21 16:24       ` Kim Phillips
2008-05-21 16:37         ` Scott Wood
2008-05-21 12:40   ` Shinya Kuribayashi
2008-05-21 13:34     ` Wolfgang Denk
2008-05-21 14:12       ` Shinya Kuribayashi
2008-05-21 14:57         ` Wolfgang Denk
2008-05-21 14:44       ` Magnus Lilja
2008-05-21 14:59         ` Wolfgang Denk
2008-05-21 15:40       ` Kim Phillips
2008-05-21 17:03   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4833470B.6000904@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.