Re: [X86] Add a boot parameter to force-enable PAT

[Rene Herman <rene.herman@keyaccess.nl>]

On 20-05-08 21:58, Dave Jones wrote:

> diff --git a/arch/x86/kernel/cpu/addon_cpuid_features.c b/arch/x86/kernel/cpu/addon_cpuid_features.c
> index c2e1ce3..e22e809 100644
> --- a/arch/x86/kernel/cpu/addon_cpuid_features.c
> +++ b/arch/x86/kernel/cpu/addon_cpuid_features.c
> @@ -50,9 +50,27 @@ void __cpuinit init_scattered_cpuid_features(struct cpuinfo_x86 *c)
>  	}
>  }
>  
> +static int forcepat;
> +
> +static int __init x86_forcepat_setup(char *s)
> +{
> +	forcepat = 1;
> +	return 1;
> +}
> +__setup("enablepat", x86_forcepat_setup);

This should probably be called plain "pat" to mirror arch/x86/mm/pat.c 
"nopat" force off parameter. That by the way is an early_param which I 
guess this should then also be?

> +
> +
>  #ifdef CONFIG_X86_PAT
>  void __cpuinit validate_pat_support(struct cpuinfo_x86 *c)
>  {
> +	if (!test_cpu_cap(c, X86_FEATURE_PAT))
> +		return;

It seems you needn't test this, the !cpu_has_pat test in pat_init() will 
trigger and user knows best... :-)

> +
> +	if (forcepat == 1) {
> +		printk(KERN_INFO "Force enabling PAT\n");
> +		return;
> +	}
> +
>  	switch (c->x86_vendor) {
>  	case X86_VENDOR_AMD:
>  		if (c->x86 >= 0xf && c->x86 <= 0x11)

Rene.