All of lore.kernel.org
 help / color / mirror / Atom feed
From: "François Revol" <revol@free.fr>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c	into usb-hid.c
Date: Wed, 29 Apr 2009 11:30:29 +0200 CEST	[thread overview]
Message-ID: <4833947677-BeMail@laptop> (raw)
In-Reply-To: <alpine.DEB.1.00.0904291042360.8215@intel-tinevez-2-302>

> > > > http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233
> > > > > > >
> > > Reading something like this in a Git log, sitting 30k feet above
> > > ground, makes me want to do something very foolish.
>
> To illustrate what commit messages in typical Git repositories look
> like:
>
> http://repo.or.cz/w/git.git?a=commitdiff;h=8d2dfc49b199c7da6faefd7993630f24bd37fee0
> >
> (answering a link with a link is okay, I think.)

Typical commit line counts in QEMU tends to be quite lower :

# count lines
$ git log | awk '/^    ..*$/{cnt++;/*print*/};NR>1&&/^commit/{print
cnt; cnt="0"}' | sort -g | uniq -c | sort -g -k 1 -r
   4904 2
    798 3
    354 4
    255 5
    239 6
    172 7
    103 8
     85 9
     59 10
     36 12
     33 11
     28 13
     21 14
     15 18
     14 15
      9 16
      9 1
      6 21
      6 20
      5 17
      4 25
      4 23
      3 24
      2 37
      2 31
      2 26
      2 19
      1 68
      1 62
      1 59
      1 41
      1 38
      1 36
      1 35
      1 34
      1 33
      1 32

Which isn't a problem in itself...

> The point is that nobody needs to sift through long and dispersed
> discussions with a lot of points that are moot in the end.  If more
> than
> one person reads the summary of the discussions in the commit
> message, the
> overall saved time (integrated over all involved people) is
> substantial.

The problem is everytime I've spent time explaining the patch, like 2
ppl read it and gave thoughtfull comments. Which should be enough but I
just got fed up spending hours ingurGITating man pages.

Besides, you still didn't even comment on the patch itself yet, which
quites asserts this.

François.

  reply	other threads:[~2009-04-29  9:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 21:26 [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c François Revol
2009-04-28 22:10 ` *** GMX Spamverdacht *** " Johannes Schindelin
2009-04-28 22:22   ` François Revol
2009-04-28 22:29     ` Johannes Schindelin
2009-04-28 22:45       ` François Revol
2009-04-29  8:45         ` Johannes Schindelin
2009-04-29  9:30           ` François Revol [this message]
2009-04-29 10:01             ` Markus Armbruster
2009-04-29 10:23               ` François Revol
2009-04-29 16:27                 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4833947677-BeMail@laptop \
    --to=revol@free.fr \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.