Re: [Qemu-devel] [PATCH 3/3] MusicPal: Add specific -hold-button option

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Paul Brook wrote:
>> MusicPal's U-Boot is able to start in a special mode (firmware recovery)
>> in case one of the control buttons is pressed during power-up. As with
>> QEMU, there is no chance to achieve this by hand (except for
>> artificially delaying the power-up with sleep()), this patch adds a
>> MusicPal-specific command line option -hold-button. The option takes
>> button codes and simulates those buttons as pressed on power-up.
> 
> There's no reason why this should be limited to the musicpal.  Better would be 
> to implement it in the input layer and have to work with all machines.

Hmm... hard to argue against. Will look into this.

But I hope this doesn't make the other two patches in this serious
obsolete in your eyes. I would still like to see them go in, at least
the first one (until there is an in-tree use case for the second one).

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]