Re: [kvm-devel] [RFC][PATCH 2/4] kvm: Arch-specifc KVM_EXIT_DEBUG payload

[Avi Kivity <avi@qumranet.com>]

Jan Kiszka wrote:
> This adds an arch field to kvm_run.debug, the payload that is returned
> to user space on KVM_EXIT_DEBUG guest exits. For x86, this field is now
> supposed to report the precise debug exception (#DB or #BP) and the
> current state of the debug registers (the latter is not yet
> implemented).
>  
> +struct kvm_debug_exit_arch {
> +	__u32 exception;
>   

Need padding here.

> +	__u64 dr[8];
> +};
> +
>   

In general I prefer decoding bitfields into something more usable (see 
for example the segment registers), but in this case, I guess the raw 
registers are better.

We need to handle branch tracing and last branch recording as well.  It 
doesn't have to be in this patchset, though.

-- 
error compiling committee.c: too many arguments to function