From: Patrick McHardy <kaber@trash.net>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Paul Moore <paul.moore@hp.com>, James Morris <jmorris@namei.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 3/4] add support for modifying secmark via ctnetlink
Date: Wed, 21 May 2008 19:13:17 +0200 [thread overview]
Message-ID: <4834582D.8090009@trash.net> (raw)
In-Reply-To: <1211388856.7486.366.camel@moss-spartans.epoch.ncsc.mil>
Stephen Smalley wrote:
> On Wed, 2008-05-21 at 12:46 -0400, Paul Moore wrote:
>>
>> I agree with James that we need to perform some access check before
>> setting the ct->secmark field, however, I don't think it is as simple
>> as calling selinux_secmark_relabel_packet_permission(). The problem is
>> that the selinux_secmark_relabel_packet_permission() function checks to
>> see if the currently running task can relabel packets; in this case we
>> don't want to check the currently running task we want to check the
>> sender of the netlink message which we can't really do currently.
>
> Sending task SID is saved in NETLINK_CB(skb).sid at send time, so the
> information is available (but would need to be passed into the
> function).
This part can actually be removed from af_netlink, see the message
I just sent to Paul for reference.
next prev parent reply other threads:[~2008-05-21 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 22:29 [PATCH 3/4] add support for modifying secmark via ctnetlink Pablo Neira Ayuso
2008-05-21 11:15 ` Patrick McHardy
2008-05-21 11:42 ` James Morris
2008-05-21 12:00 ` Patrick McHardy
2008-05-21 16:46 ` Paul Moore
2008-05-21 16:54 ` Stephen Smalley
2008-05-21 17:13 ` Patrick McHardy [this message]
2008-05-22 18:11 ` Stephen Smalley
2008-05-22 19:08 ` Patrick McHardy
2008-05-21 17:41 ` Paul Moore
2008-05-21 17:11 ` Patrick McHardy
2008-05-21 17:51 ` Paul Moore
2008-05-21 17:55 ` Stephen Smalley
2008-05-21 19:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4834582D.8090009@trash.net \
--to=kaber@trash.net \
--cc=jmorris@namei.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.