From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936070AbYEUS6f (ORCPT ); Wed, 21 May 2008 14:58:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757237AbYEUS6X (ORCPT ); Wed, 21 May 2008 14:58:23 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:57251 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756438AbYEUS6W (ORCPT ); Wed, 21 May 2008 14:58:22 -0400 Message-ID: <4834704D.6020809@cs.helsinki.fi> Date: Wed, 21 May 2008 21:56:13 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: Christoph Lameter CC: linux-kernel@vger.kernel.org, mpm@selenic.com, lethal@linux-sh.org, dhowells@redhat.com Subject: Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > Why is it too big? Without your additions it is converting kmallocs > inline to get_free_pages(). That results in a simple function call with > two constant parameters. Well, it's a PITA because of #include dependencies in any case. Is moving it out-of-line a problem? Christoph Lameter wrote: > The patch touches the page struct uselessly. I think the PageSlab marking > is useful for debugging but not for a production kernel. Hmm, where? page_address() already references ->virtual. I suppose CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from kfree() as spotted by Vegard Nossum.) Pekka