All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Reed <mdr@sgi.com>
To: linux-scsi <linux-scsi@vger.kernel.org>,
	"Moore, Eric" <Eric.Moore@lsi.com>,
	"Prakash, Sathya" <Sathya.Prakash@lsi.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 1/1] Fusion: SAS: don't set queue depth to 1 when sdev->id is greater than sh->max_id
Date: Wed, 21 May 2008 15:21:28 -0500	[thread overview]
Message-ID: <48348448.4020508@sgi.com> (raw)

This patch was originally part of a patch posted March 13, 2008.
I'm breaking this out into a separate patch as it's only somewhat related.
Applies cleanly against Sathya's latest patch and will apply correctly
(offset +29) to 2.6.26-rc3-git3.

--

Change mptscsih_slave_configure so it doesn't set the queue depth to 1 for SAS
protocol when sdev->id is greater than sh->max_id.   The sas transport
layer assigns the target ids, incrementing with each hotplug add.  With
large topologies, it doesn't take long to hit this threshold.

Signed-off-by: Michael Reed <mdr@sgi.com>


--- linux-2.6.26-rc3-git3.orig/drivers/message/fusion/mptscsih.c	2008-05-21 15:06:59.212691745 -0500
+++ linux-2.6.26-rc3-git3/drivers/message/fusion/mptscsih.c	2008-05-21 15:08:04.323836957 -0500
@@ -2422,12 +2422,6 @@ mptscsih_slave_configure(struct scsi_dev
 		    ioc->name, sdev->sdtr, sdev->wdtr,
 		    sdev->ppr, sdev->inquiry_len));
 
-	if (sdev->id > sh->max_id) {
-		/* error case, should never happen */
-		scsi_adjust_queue_depth(sdev, 0, 1);
-		goto slave_configure_exit;
-	}
-
 	vdevice->configured_lun = 1;
 	mptscsih_change_queue_depth(sdev, MPT_SCSI_CMD_PER_DEV_HIGH);
 
@@ -2441,8 +2435,6 @@ mptscsih_slave_configure(struct scsi_dev
 		    ioc->name, vtarget->negoFlags, vtarget->maxOffset,
 		    vtarget->minSyncFactor));
 
-slave_configure_exit:
-
 	dsprintk(ioc, printk(MYIOC_s_DEBUG_FMT
 		"tagged %d, simple %d, ordered %d\n",
 		ioc->name,sdev->tagged_supported, sdev->simple_tags,

             reply	other threads:[~2008-05-21 20:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 20:21 Michael Reed [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-05-22 17:49 [PATCH 1/1] Fusion: SAS: don't set queue depth to 1 when sdev->id is greater than sh->max_id Prakash, Sathya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48348448.4020508@sgi.com \
    --to=mdr@sgi.com \
    --cc=Eric.Moore@lsi.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Sathya.Prakash@lsi.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.