Re: [PATCH] serial: fix enable_irq_wake/disable_irq_wake imbalance in serial_core.c

[Arjan van de Ven <arjan@linux.intel.com>]

Andrew Morton wrote:
>>  	}
>>  
>> -	if (!port->suspended) {
>> +	tty_dev = device_find_child(port->dev, &match, serial_match_port);
>> +	if (!port->suspended && device_may_wakeup(tty_dev)) {
>>  		disable_irq_wake(port->irq);
>>  		mutex_unlock(&state->mutex);
>>  		return 0;
> 
> erp, is that the easiest way of going from a uart_driver* to a device*?
> Doing a lookup each time is a bit unusual.
> 

this is during suspend/resume only, so I figured it wasn't going to be that performance critical;
I wanted the code to be as symmetric as possible rather than fastest..