From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935082AbYEVKPx (ORCPT ); Thu, 22 May 2008 06:15:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933330AbYEVKPj (ORCPT ); Thu, 22 May 2008 06:15:39 -0400 Received: from e28smtp02.in.ibm.com ([59.145.155.2]:48549 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935504AbYEVKPi (ORCPT ); Thu, 22 May 2008 06:15:38 -0400 Message-ID: <4835477D.1020609@linux.vnet.ibm.com> Date: Thu, 22 May 2008 15:44:21 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Andrew Morton CC: linux-mm@kvack.org, Sudhir Kumar , YAMAMOTO Takashi , Paul Menage , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, Pavel Emelianov , KAMEZAWA Hiroyuki Subject: Re: [-mm][PATCH 3/4] cgroup mm owner callback changes to add task info (v5) References: <20080521152921.15001.65968.sendpatchset@localhost.localdomain> <20080521152959.15001.14495.sendpatchset@localhost.localdomain> <20080521211958.ca4f733c.akpm@linux-foundation.org> In-Reply-To: <20080521211958.ca4f733c.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Wed, 21 May 2008 20:59:59 +0530 Balbir Singh wrote: > >> This patch adds an additional field to the mm_owner callbacks. This field >> is required to get to the mm that changed. Hold mmap_sem in write mode >> before calling the mm_owner_changed callback >> >> ... >> >> + * The callbacks are invoked with mmap_sem held in read mode. > > Is that true? > >> + down_write(&mm->mmap_sem); >> ... >> cgroup_mm_owner_callbacks(mm->owner, c); > > Looks like write-mode to me? Yes, obsolete comment. Will fix. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by e28esmtp07.in.ibm.com (8.13.1/8.13.1) with ESMTP id m4MAFMgB032502 for ; Thu, 22 May 2008 15:45:22 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4MAFAG01188038 for ; Thu, 22 May 2008 15:45:10 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.13.1/8.13.3) with ESMTP id m4MAEmxL023165 for ; Thu, 22 May 2008 15:44:48 +0530 Message-ID: <4835477D.1020609@linux.vnet.ibm.com> Date: Thu, 22 May 2008 15:44:21 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com MIME-Version: 1.0 Subject: Re: [-mm][PATCH 3/4] cgroup mm owner callback changes to add task info (v5) References: <20080521152921.15001.65968.sendpatchset@localhost.localdomain> <20080521152959.15001.14495.sendpatchset@localhost.localdomain> <20080521211958.ca4f733c.akpm@linux-foundation.org> In-Reply-To: <20080521211958.ca4f733c.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: linux-mm@kvack.org, Sudhir Kumar , YAMAMOTO Takashi , Paul Menage , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, Pavel Emelianov , KAMEZAWA Hiroyuki List-ID: Andrew Morton wrote: > On Wed, 21 May 2008 20:59:59 +0530 Balbir Singh wrote: > >> This patch adds an additional field to the mm_owner callbacks. This field >> is required to get to the mm that changed. Hold mmap_sem in write mode >> before calling the mm_owner_changed callback >> >> ... >> >> + * The callbacks are invoked with mmap_sem held in read mode. > > Is that true? > >> + down_write(&mm->mmap_sem); >> ... >> cgroup_mm_owner_callbacks(mm->owner, c); > > Looks like write-mode to me? Yes, obsolete comment. Will fix. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org