From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@inl.fr>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>, Anton <anton.vazir@gmail.com>
Subject: Re: [PATCH] simplify list handing in ifname2index infrastructure
Date: Thu, 22 May 2008 15:02:53 +0200 [thread overview]
Message-ID: <48356EFD.4000704@netfilter.org> (raw)
In-Reply-To: <20080522125443.GL7436@bayen.regit.org>
Eric Leblond wrote:
> Hello,
>
> On Thursday, 2008 May 22 at 14:19:12 +0200, Pablo Neira Ayuso wrote:
>> Hi!
>>
>> The patch attached simplifies the ifname2index list handling by using
>> linux list and it introduces minor cleanups such as remove iftb_log()
>> calls. This patch also fixes the leak in the nlif_close path (we forgot
>> to release the ifindex nodes from the hashes) that Anton has reported.
>>
>> Slightly tested here. If you are OK with it I'll apply it asap.
>
> Maybe, this patch is a little too much for a code which should disappear for
> libnl ?
Well, the current code is broken and we have to fix it anyway. If you
don't have any other objection I'll apply it asap.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2008-05-22 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 12:19 [PATCH] simplify list handing in ifname2index infrastructure Pablo Neira Ayuso
2008-05-22 12:54 ` Eric Leblond
2008-05-22 13:02 ` Pablo Neira Ayuso [this message]
2008-05-22 13:09 ` Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48356EFD.4000704@netfilter.org \
--to=pablo@netfilter.org \
--cc=anton.vazir@gmail.com \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.