All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mips: If CONFIG_CMD_SPI is defined, call spi_init()
Date: Fri, 23 May 2008 00:03:07 +0900	[thread overview]
Message-ID: <48358B2B.7040301@ruby.dti.ne.jp> (raw)
In-Reply-To: <20080521204118.2B94466126@mcmullan-linux.hq.netapp.com>

Jason McMullan wrote:
> The mips architecture currently does not call 'spi_init()'
> in the generic board initialization routine is CONFIG_CMD_SPI
> is defined.
> 
> This patch rectifies that problem.
> 
> Signed-off-by: Jason McMullan <mcmullan@netapp.com>

Applied with two CodingStyle fixes. See below.

> @@ -422,6 +423,12 @@ void board_init_r (gd_t *id, ulong dest_addr)
>  	nand_init();		/* go init the NAND */
>  #endif
>  
> +#ifdef CONFIG_CMD_SPI
> +	puts("SPI:   ");
            ^

> +	spi_init();		/* go init the SPI */
                ^

> +	puts ("ready\n");
> +#endif
> +
>  #if defined(CONFIG_MISC_INIT_R)
>  	/* miscellaneous platform dependent initialisations */
>  	misc_init_r ();

Note that I'm Linux's CodingStyle lover. But in this case, we should use
the same CodingStyle in a single file.

Thanks,

  Shinya

      reply	other threads:[~2008-05-22 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 20:39 [U-Boot-Users] [PATCH] mips: If CONFIG_CMD_SPI is defined, call spi_init() Jason McMullan
2008-05-22 15:03 ` Shinya Kuribayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48358B2B.7040301@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.