All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabian Hugelshofer <hugelshofer2006@gmx.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [0/3] conntrack event kernel issues
Date: Fri, 23 May 2008 14:13:48 +0100	[thread overview]
Message-ID: <4836C30C.8020305@gmx.ch> (raw)
In-Reply-To: <4836ACA9.5040507@trash.net>

Patrick McHardy wrote:
>> Then there is this thing with the TCP RST. I think, that the event 
>> data should be accurate. If the status is returned (with patch 1), 
>> then it should have the SEEN_REPLY flag set. Another issue is that the 
>> accounting counters are not updated. IMHO this should be done as well 
>> (is not in my patches).
> 
> Fully agreed about the counters. About the SEEN_REPLY bit - that
> depends on how you define its meaning. So far its only set if
> a valid reply for the connection is seen - which a RST isn't.

I consider a RST as a valid reply for a connection. It matches the tuple 
and is in reply direction (ctinfo is set to IS_REPLY). Further the TCP 
protocol handler returns no error. The SEEN_REPLY bit is actually set at 
the end of nf_conntrack_in() but the destroy event is already triggered 
by the TCP handler.

Increasing the counters in reply direction without setting the 
SEEN_REPLY bit seems a bit weird to me.

  parent reply	other threads:[~2008-05-23 13:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22  9:12 [0/3] conntrack event kernel issues Fabian Hugelshofer
2008-05-23 10:03 ` Patrick McHardy
2008-05-23 11:32   ` Fabian Hugelshofer
2008-05-23 11:38     ` Patrick McHardy
2008-05-23 12:10       ` Pablo Neira Ayuso
2008-05-23 12:20         ` Pablo Neira Ayuso
2008-05-23 13:13       ` Fabian Hugelshofer [this message]
2008-05-25 14:57         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4836C30C.8020305@gmx.ch \
    --to=hugelshofer2006@gmx.ch \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.