From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 18/18] avr32: Compile atmel_mci.oconditionally
Date: Fri, 23 May 2008 14:24:32 -0500 [thread overview]
Message-ID: <483719F0.2080601@freescale.com> (raw)
In-Reply-To: <AA28F077645B324881335614E4F7C428034D92@win-ex01.bench.com>
Ken.Fuchs at bench.com wrote:
> Haavard Skinnemoen wrote:
>
>> Remove #ifdef CONFIG_MMC from the source file and use conditional
>> compilation in the Makefile instead.
>
> What's wrong with the current code? Why are you doing this?
>
Because it is the right thing to do. :-)
So that we don't gratuitously compile files that
aren't even necessarily involved in the build
as per configuration selections. This is all
part of the longer term goal of moving to a
Kconfig/Kbuild mechanism.
jdl
next prev parent reply other threads:[~2008-05-23 19:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 12:36 [U-Boot-Users] [PATCH 00/18] avr32 patches for 1.3.4 Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 01/18] avr32: stk1002 and ngw100 convergence Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 02/18] avr32: Disable the AP7000 internal watchdog on startup Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 03/18] avr32: Use correct condition around macb clock accessors Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 04/18] avr32: Remove unneeded .flashprog section from NGW100 ldscript Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 05/18] avr32: Get rid of the .flashprog section Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 06/18] avr32: Add support for the ATSTK1006 board Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 07/18] avr32: Clean up the HMATRIX code Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 08/18] avr32: Remove unused file cpu/at32ap/pm.c Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 09/18] avr32: Use new-style Makefile for the at32ap platform Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 10/18] avr32: Rename pm_init() as clk_init() and make SoC-specific Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 11/18] avr32: Put memset in its own section Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 12/18] avr32: Use the same entry point for reset and exception handling Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 13/18] avr32: Do stricter stack checking in the exception handler Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 14/18] avr32: Rework SDRAM initialization code Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 15/18] atmel_usart: Support fractional baud rate dividers Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 16/18] avr32: Fix two warnings in atmel_mci.c Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 17/18] avr32: Fix wrong error flags in atmel_mci driver Haavard Skinnemoen
2008-05-23 12:36 ` [U-Boot-Users] [PATCH 18/18] avr32: Compile atmel_mci.o conditionally Haavard Skinnemoen
2008-05-23 19:01 ` [U-Boot-Users] [PATCH 18/18] avr32: Compile atmel_mci.oconditionally Ken.Fuchs at bench.com
2008-05-23 19:24 ` Jon Loeliger [this message]
2008-05-26 5:12 ` [U-Boot-Users] [PATCH 18/18] avr32: Compileatmel_mci.oconditionally Ulf Samuelsson
2008-05-23 18:54 ` [U-Boot-Users] [PATCH 16/18] avr32: Fix two warnings in atmel_mci.c Ken.Fuchs at bench.com
2008-05-23 19:04 ` Scott Wood
2008-05-24 14:48 ` Haavard Skinnemoen
2008-05-27 13:17 ` [U-Boot-Users] [PATCH 15/18] atmel_usart: Support fractional baud rate dividers Haavard Skinnemoen
2008-05-23 21:24 ` [U-Boot-Users] [PATCH 06/18] avr32: Add support for the ATSTK1006 board Jean-Christophe PLAGNIOL-VILLARD
2008-05-24 14:58 ` Haavard Skinnemoen
2008-05-23 21:18 ` [U-Boot-Users] [PATCH 05/18] avr32: Get rid of the .flashprog section Jean-Christophe PLAGNIOL-VILLARD
2008-05-24 15:03 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483719F0.2080601@freescale.com \
--to=jdl@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.