All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: "Tan, Li" <li.tan@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvmtrace_format for supporting big_endian
Date: Sun, 25 May 2008 12:34:21 +0300	[thread overview]
Message-ID: <4839329D.9080100@qumranet.com> (raw)
In-Reply-To: <08DF4D958216244799FC84F3514D70F00164C67D@pdsmsx415.ccr.corp.intel.com>

Tan, Li wrote:
> I meant, you can change the definitions of D3REC, D4REC, etc. and not
> worry about reversing once you've decoded the magic word.
>
>   

> [tan] so it looks like:
> 	 if reverse_flag == 0: 
> 			#    print "host and data file are same endian order"
> 			D3REC  = "III"
> 			D4REC  = "IIII"
> 			D5REC  = "IIIII"
> 	else:
> 		If pack('<h', 1) == pack('=h',1):
> 			#    print "host is Little Endian, data file is big endian"
> 			D3REC  = ">III"
> 			D4REC  = ">IIII"
> 			D5REC  = ">IIIII"
> 		elif pack('>h', 1) == pack('=h',1): 
> 			#    print "host is big Endian, data file is little endian"
> 			D3REC  = "<III"
> 			D4REC  = "<IIII"
> 			D5REC  = "<IIIII"
>   

Not sure about the tests. You aren't looking at the data from the file,
how can you conclude it's little endian or big endian?

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-05-25  9:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <08DF4D958216244799FC84F3514D70F0015B1B58@pdsmsx415.ccr.corp.intel.com>
2008-05-14 21:37 ` [kvm-ppc-devel] kvm trace support for ppc Hollis Blanchard
2008-05-14 21:37   ` Hollis Blanchard
2008-05-15  1:20   ` [kvm-ppc-devel] " Tan, Li
2008-05-15  1:20     ` Tan, Li
2008-05-16  6:26   ` [kvm-ppc-devel] " Tan, Li
2008-05-16  6:26     ` Tan, Li
2008-05-20  6:53   ` [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian Tan, Li
2008-05-20  7:03     ` [PATCH] [RFC][PATCH] kvm: kvmtrace: kvmtrace_format " Tan, Li
2008-05-20 16:22       ` Avi Kivity
2008-05-21  7:36         ` Tan, Li
2008-05-21  9:21           ` Avi Kivity
2008-05-22  0:30             ` Tan, Li
2008-05-25  9:34               ` Avi Kivity [this message]
2008-05-26  5:38                 ` Tan, Li
2008-05-28 11:17                   ` Avi Kivity
2008-06-02  1:25                     ` Tan, Li
2008-05-20 16:25     ` [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4839329D.9080100@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    --cc=li.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.