From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [MIPS] Convert CPU type name into CONFIG_CPU_*
Date: Mon, 26 May 2008 00:15:40 +0900 [thread overview]
Message-ID: <4839829C.9040000@ruby.dti.ne.jp> (raw)
In-Reply-To: <20080524200908.593BC247F5@gemini.denx.de>
Wolfgang Denk wrote:
> In message <48381B6C.5000901@ruby.dti.ne.jp> you wrote:
>> Adjust to the current Linux way.
>>
>> Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
> ...
>> -#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
>> +#define CONFIG_CPU_MIPS32_R1 1 /* MIPS32 CPU core */
>
> I have to admit that I don't like this changes.
>
> We're adding a lot of fine ganularity here
First of all, current CONFIG_MIPS32 defines are useless. We can even
remove them. What is fine granularity for, huh?
skuribay at debian:~/devel/u-boot.git$ grep -r CONFIG_MIPS32 .
./include/configs/qemu-mips.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/dbau1x00.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/gth2.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/purple.h:#define CONFIG_MIPS32 1 /* MIPS 5Kc CPU core */
./include/configs/tb0229.h:#define CONFIG_MIPS32 1 /* MIPS 4Kc CPU core */
./include/configs/pb1x00.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/incaip.h:#define CONFIG_MIPS32 1 /* MIPS 4Kc CPU core */
skuribay at debian:~/devel/u-boot.git$
[btw tb0229 is not MIPS32 at all. it's VR4131 based machine.]
> What exactly is the reason for all these changes? Which problem are
> you trying to fix?
It'll be good we could have CPU type specifier so that we can utilize as
a compiler/assembler optimization.
And why I use CONFIG_CPU_MIPS32_R1, instead of CONFIG_CPU_MIPS32, is due
to avoiding #ifdef mess. CONFIG_CPU_MIPS32 is inadequate for this use.
We need _R1 or _R2. Linux is doing well with the help of Kconfig.
Probably I should have fold this patch and `[MIPS] CPU-dependent
compiler/assembler options for optimization' patch into one.
Thought?
Shinya
next prev parent reply other threads:[~2008-05-25 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-24 13:43 [U-Boot-Users] [MIPS] Convert CPU type name into CONFIG_CPU_* Shinya Kuribayashi
2008-05-24 20:09 ` Wolfgang Denk
2008-05-25 15:15 ` Shinya Kuribayashi [this message]
2008-05-25 15:35 ` Wolfgang Denk
2008-05-31 5:32 ` Shinya Kuribayashi
2008-07-05 22:32 ` Wolfgang Denk
2008-07-06 3:17 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4839829C.9040000@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.