All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Future plans for sensors-detect
Date: Sun, 25 May 2008 21:20:40 +0000	[thread overview]
Message-ID: <4839D828.1010900@hhs.nl> (raw)
In-Reply-To: <20080521114013.074cde02@hyperion.delvare>

Jean Delvare wrote:
> Hi Hans,
> 
> For completeness...
> 
>> I was also thinking that user-friendly distributions might want to
>> automatize the process of setting up the sensors as part of the system
>> installation. There are many improvements needed before this can
>> happen, such as a command line interface / non-interactive mode to
>> sensors-detect and DMI support, but speeding up the detection itself
>> would also help, I think.
> 
> Note: when sensors-detect goes non-interactive, you are more likely to
> notice how slow SMBus probing is. For now, most time is wasted waiting
> for the user to answer questions, so you don't really notice, unless
> you're using HZ\x100.
> 

Are you really planning on doing non interactive i2c probing from the 
initscript? To me that feels wrong:
1) Only 101% safe probing should be done non interactive
2) Even if we can safely determine which hwmon drivers should be loaded,
    we still should not load them without also having a valid
    matching motherboard sensors.conf

The reason for 2 is that its better to show no readings to an uneducated users 
then to show wrong readings which make him/her think his/her machine is about 
to blow up.

>> I wouldn't consider it if the patch was intrusive, but it's pretty
>> small if you look at it.
> 
> After removing the word register cache (recent changes to the script
> make it hardly worth caching word reads) and the instrumentation code,
> the patch only adds 8 lines of code. The diffstat reads:
> 

I guess its worth it then :)

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2008-05-25 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  9:40 [lm-sensors] Future plans for sensors-detect Jean Delvare
2008-05-21 11:29 ` Hans de Goede
2008-05-22 11:50 ` Jean Delvare
2008-05-23 22:13 ` Juerg Haefliger
2008-05-24  6:59 ` Jean Delvare
2008-05-25 21:20 ` Hans de Goede [this message]
2008-05-26 10:06 ` Jean Delvare
2008-06-08 11:45 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4839D828.1010900@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.