From: Lea Wiemann <lewiemann@gmail.com>
To: Lea Wiemann <lewiemann@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: only display "next" links in logs if there is a next page
Date: Wed, 28 May 2008 01:30:42 +0200 [thread overview]
Message-ID: <483C99A2.90909@gmail.com> (raw)
In-Reply-To: <1211930742-24978-1-git-send-email-LeWiemann@gmail.com>
Lea Wiemann wrote:
> There was a bug in the implementation of the "next" links in
> format_paging_nav (for log and shortlog), which caused the next links
> to always be displayed, even if there is no next page. This fixes it.
Oh, one more thing I forgot to mention: I've tested this with a small
(single-page) log page and a long log page. In both cases the "next"
links get formatted correctly, and they stop linking to the next page on
the correct (= last) page. The only thing I haven't tested for is
off-by-one errors, but I'm reasonably sure that $#commitlist >= 100 is
right.
-- Lea
next prev parent reply other threads:[~2008-05-27 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 22:31 [PATCH] gitweb: only display "next" links in logs if there is a next page Lea Wiemann
2008-05-27 23:08 ` Junio C Hamano
2008-05-27 23:23 ` Lea Wiemann
2008-05-27 23:25 ` Lea Wiemann
2008-05-27 23:30 ` Lea Wiemann [this message]
2008-05-28 0:04 ` Junio C Hamano
2008-05-28 0:10 ` Lea Wiemann
2008-05-28 9:01 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483C99A2.90909@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.