From: Patrick McHardy <kaber@trash.net>
To: Fabian Hugelshofer <hugelshofer2006@gmx.ch>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] accounting on ct kill
Date: Wed, 28 May 2008 06:07:30 +0200 [thread overview]
Message-ID: <483CDA82.8090802@trash.net> (raw)
In-Reply-To: <1211928920.14366.12.camel@pumper.lan.luxnet.ch>
Fabian Hugelshofer wrote:
> Introduces nf_ct_kill_acct() which increments the accounting counters on
> conntrack kill. The new function was necessary, because there are calls
> to nf_ct_kill() which don't need accounting:
>
> nf_conntrack_proto_tcp.c line ~847:
> Kills ct and returns NF_REPEAT. We don't want to count twice.
>
> nf_conntrack_proto_tcp.c line ~880:
> Kills ct and returns NF_DROP. I think we don't want to count dropped
> packets.
>
> nf_conntrack_netlink.c line ~824:
> As far as I can see ctnetlink_del_conntrack() is used to destroy a
> conntrack on behalf of the user. There is an sk_buff, but I don't think
> this is an actual packet. Incrementing counters here is therefore not
> desired.
Good points. Applied, thanks Fabian.
I've also pulled in Dave's latest net-next-2.6.git tree and will
push it out now.
next prev parent reply other threads:[~2008-05-28 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 9:13 [PATCH 2/3] set SEEN_REPLY before destroying conntrack on TCP RST Fabian Hugelshofer
2008-05-26 18:25 ` Fabian Hugelshofer
2008-05-27 4:53 ` Patrick McHardy
2008-05-27 14:33 ` Fabian Hugelshofer
2008-05-27 14:48 ` Patrick McHardy
2008-05-27 22:55 ` [PATCH 2/3] accounting on ct kill (was: set SEEN_REPLY before destroying conntrack on TCP RST) Fabian Hugelshofer
2008-05-28 4:07 ` Patrick McHardy [this message]
2008-05-28 8:36 ` [PATCH 2/3] accounting on ct kill Fabian Hugelshofer
2008-06-10 9:22 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483CDA82.8090802@trash.net \
--to=kaber@trash.net \
--cc=hugelshofer2006@gmx.ch \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.