From: Sam Vilain <sam@vilain.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [BISECTED] git-svn: "Failed to read object ..." during clone
Date: Wed, 28 May 2008 19:28:13 +1200 [thread overview]
Message-ID: <483D098D.5010302@vilain.net> (raw)
In-Reply-To: <7vskw3vsys.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Heh, I should have been more careful. The series introduces Git::cat_blob
> that returns the size of a blob but the interface is broken and signals
> error by returning zero. e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 is a
> zero sized blob.
>
> Would this be enough?
> my $size = $::_repository->cat_blob($fb->{blob}, $base);
> - die "Failed to read object $fb->{blob}" unless $size;
> + die "Failed to read object $fb->{blob}" if ($size < 0);
Heh. This sort of thing is why perl has "undef"; you could make that
"unless defined $size" and "return undef" in the functions.
Sam
next prev parent reply other threads:[~2008-05-28 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 3:01 [BISECTED] git-svn: "Failed to read object ..." during clone Björn Steinbrink
2008-05-28 6:32 ` Junio C Hamano
2008-05-28 7:28 ` Sam Vilain [this message]
2008-05-28 14:19 ` Björn Steinbrink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483D098D.5010302@vilain.net \
--to=sam@vilain.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.