From: James Kosin <jkosin@beta.intcomgrp.com>
To: linux-kernel@vger.kernel.org
Subject: Re: optimizing out inline functions
Date: Wed, 28 May 2008 16:37:31 -0400 [thread overview]
Message-ID: <483DC28B.4060001@support.intcomgrp.com> (raw)
In-Reply-To: <ayA8E-89e-29@gated-at.bofh.it>
Sam Ravnborg wrote:
> On Wed, May 28, 2008 at 02:51:02PM -0500, Steve French wrote:
>> In trying to remove some macros, I ran across another kernel style
<<--SNIP-->>
> With reference to a recent thread about kconfig
> I would prefer:
> static inline void some_debug_function(var1)
> {
> if (KCONFIG_DEBUG_SOMETHING) {
> something = var1;
> printk(some debug text);
> }
> }
>
>
> But we do not have KCONFIG_DEBUG_SOMETHING available
> so the second best is to use an empty function
> to keep the typechecking in place.
>
> IIRC gcc optimize both away.
Another way would be to have:
static inline void some_debug_function(var1)
{
#ifdef KCONFIG_DEBUG_SOMETHING
something = var1;
printk(some debug text);
#endif
}
BUT, this probably violates some styling rules.
James
}
next parent reply other threads:[~2008-05-28 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ayzYV-7mv-5@gated-at.bofh.it>
[not found] ` <ayA8E-89e-29@gated-at.bofh.it>
2008-05-28 20:37 ` James Kosin [this message]
2008-05-29 3:27 ` optimizing out inline functions Johannes Weiner
2008-05-29 3:04 ` Joe Perches
2008-05-29 13:11 ` James Kosin
2008-05-29 13:13 ` James Kosin
2008-05-28 19:51 Steve French
2008-05-28 19:54 ` Pekka Enberg
2008-05-29 8:40 ` Andrew Morton
2008-05-28 20:00 ` Sam Ravnborg
2008-05-29 16:39 ` Steve French
2008-05-29 17:20 ` Sam Ravnborg
2008-06-02 9:38 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483DC28B.4060001@support.intcomgrp.com \
--to=jkosin@beta.intcomgrp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.