From: Paolo Bonzini <bonzini@gnu.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] make commit --interactive lock index
Date: Thu, 29 May 2008 20:00:55 +0200 [thread overview]
Message-ID: <483EEF57.6060304@gnu.org> (raw)
In-Reply-To: <20080529175157.GB5596@steel.home>
>> The "if() die ()" thingie is already in builtin-commit.c, so we won't
>> ever get a pathspec in the "add --interactive" case. If we do,
>> something else has already been done incorrectly before -- not by the
>> user but by the programmer.
>
> What could that be?
Nothing, but it documents to whoever reads the code what is the path
that will be taken. Anyway if it happened it would be very bad.
Paolo
next prev parent reply other threads:[~2008-05-29 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 8:09 [PATCH] make commit --interactive lock index Paolo Bonzini
2008-05-29 12:43 ` Johannes Schindelin
2008-05-29 13:12 ` Paolo Bonzini
2008-05-29 13:55 ` Johannes Schindelin
2008-05-29 14:40 ` Paolo Bonzini
2008-05-29 17:51 ` Alex Riesen
2008-05-29 18:00 ` Paolo Bonzini [this message]
2008-05-29 18:56 ` Alex Riesen
2008-05-29 19:17 ` Paolo Bonzini
2008-05-30 5:29 ` Junio C Hamano
2008-05-30 7:42 ` Paolo Bonzini
2008-06-02 13:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483EEF57.6060304@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.